Re: patch: garbage error strings in libpq - Mailing list pgsql-patches

From jtv@xs4all.nl
Subject Re: patch: garbage error strings in libpq
Date
Msg-id 8594.202.47.227.25.1120641194.squirrel@202.47.227.25
Whole thread Raw
In response to Re: patch: garbage error strings in libpq  (Neil Conway <neilc@samurai.com>)
Responses Re: patch: garbage error strings in libpq  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway wrote:

> Per C99 6.5.2.2.10, a sequence point occurs between the evaluation of
> the arguments to a function and the call of the function itself.
> Therefore a sequence point occurs before the call to libpq_gettext(). So
> ISTM having libpq_gettext() preserve errno should work.

In C99, at least.  But that's not the dialect postgres is written in; even
gcc 4.0 leaves C99 support turned off by default.

Does anyone know what the situation is in C89, or whatever the applicable
standard is?


Jeroen



pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: INSERT ... RETURNING
Next
From: Neil Conway
Date:
Subject: Re: patch: garbage error strings in libpq