Re: BUG #13126: table constraint loses its comment - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #13126: table constraint loses its comment
Date
Msg-id 8519.1429995948@sss.pgh.pa.us
Whole thread Raw
In response to BUG #13126: table constraint loses its comment  (xi@resolvent.net)
Responses Re: BUG #13126: table constraint loses its comment  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs
xi@resolvent.net writes:
> In some circumstances, the comment on a table constraint disappears.  Here
> is an example:

Hm, yeah.  The problem is that ATExecAlterColumnType() rebuilds all the
affected indexes from scratch, and it isn't doing anything about copying
their comments to the new objects (either comments on the constraints, or
comments directly on the indexes).

The least painful way to fix it might be to charter ATPostAlterTypeCleanup
to create COMMENT commands and add those to the appropriate work queue,
rather than complicating the data structure initially emitted by
ATExecAlterColumnType.  But it'd still be a fair amount of new code I'm
afraid.

Not planning to fix this personally, but maybe someone else would like to
take it up.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: BUG #13143: Cannot stop and restart a streaming server with a replication slot
Next
From: Tom Lane
Date:
Subject: Re: contrib/start-scripts/linux failing on RHEL 6 with ~9.3 because of missing oom_score_adj