Re: Covering GiST indexes - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Covering GiST indexes
Date
Msg-id 850AE105-F89A-42E4-AD40-FBC6EA5A5A00@yandex-team.ru
Whole thread Raw
In response to Re: Covering GiST indexes  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: Covering GiST indexes
List pgsql-hackers
Hi, Thomas!

29 июля 2018 г., в 14:28, Thomas Munro <thomas.munro@enterprisedb.com> написал(а):

On Fri, Jul 6, 2018 at 5:27 AM, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
Here is v3 version of the patch. I've fixed some comments and added some words to docs.

Hi again Andrey,

Cfbot reported the following difference (twice) in the
index_including_gist test:

- ERROR: included columns must not intersect with key columns
+ ERROR: relation "tbl_gist_idx" already exists

Well, both of those errors are valid complaints in this case... maybe
the order of checks changed in master since you wrote the patch?
Probably better to use a different name for the index anyway.

Thanks! The problem appeared with commit 701fd0b [0] which dropped validation rules checked in failed test.  Here's the patch with fixed tests.

Best regards, Andrey Borodin.

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Removing unneeded self joins
Next
From: Thomas Munro
Date:
Subject: Re: [PATCH] Improve geometric types