Re: pg_restore loops forever past EOF for corrupt custom archive files - Mailing list pgsql-patches

From Chad Wagner
Subject Re: pg_restore loops forever past EOF for corrupt custom archive files
Date
Msg-id 81961ff50708051018q9df446bra87ce9b58bcae9ed@mail.gmail.com
Whole thread Raw
In response to Re: pg_restore loops forever past EOF for corrupt custom archive files  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_restore loops forever past EOF for corrupt custom archive files
List pgsql-patches

On 8/5/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
"Chad Wagner" <chad.wagner@gmail.com> writes:
> This patch modifies the ReadStr function in pg_backup_archiver.c to validate
> the result of *AH->ReadBufPtr matches the value of l.

If we're trying to defend against premature EOF, this hardly seems like
a sufficient patch.

I agree, but it is better than nothing.  If you have some suggestions or other areas of the pg_restore code that I should take a look at then I don't mind doing so.

The patch at least raises awareness to this problem.

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_restore loops forever past EOF for corrupt custom archive files
Next
From: Tom Lane
Date:
Subject: Re: pg_restore loops forever past EOF for corrupt custom archive files