Re: pg_restore loops forever past EOF for corrupt custom archive files - Mailing list pgsql-patches

From Tom Lane
Subject Re: pg_restore loops forever past EOF for corrupt custom archive files
Date
Msg-id 22424.1186331741@sss.pgh.pa.us
Whole thread Raw
In response to pg_restore loops forever past EOF for corrupt custom archive files  ("Chad Wagner" <chad.wagner@gmail.com>)
Responses Re: pg_restore loops forever past EOF for corrupt custom archive files  ("Chad Wagner" <chad.wagner@gmail.com>)
List pgsql-patches
"Chad Wagner" <chad.wagner@gmail.com> writes:
> This patch modifies the ReadStr function in pg_backup_archiver.c to validate
> the result of *AH->ReadBufPtr matches the value of l.

If we're trying to defend against premature EOF, this hardly seems like
a sufficient patch.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Chad Wagner"
Date:
Subject: pg_restore loops forever past EOF for corrupt custom archive files
Next
From: "Chad Wagner"
Date:
Subject: Re: pg_restore loops forever past EOF for corrupt custom archive files