Re: Displaying Comments in Views - Mailing list pgsql-general

From Tom Lane
Subject Re: Displaying Comments in Views
Date
Msg-id 8183.1548689278@sss.pgh.pa.us
Whole thread Raw
In response to Displaying Comments in Views  (Susan Hurst <susan.hurst@brookhurstdata.com>)
Responses Re: Displaying Comments in Views  (Susan Hurst <susan.hurst@brookhurstdata.com>)
List pgsql-general
Susan Hurst <susan.hurst@brookhurstdata.com> writes:
> What is the trick for displaying column comments in views?
> The query below works as expected when the table_schema includes tables, 
> however it shows nothing when the table_schema contains only views.

No surprise, since you're using pg_statio_all_tables as the source of
tables, and that contains, well, only tables.

I'm not quite sure why you'd choose that view anyway.  Personally I'd
have gone directly to pg_class, and then probably filtered on relkind
if there were things I didn't want to see.  Or you could use
information_schema.tables.

Also, I'm too lazy to check on how information_schema.columns defines
"ordinal_position", but I wonder if it tries to leave out dropped
columns, or might do so in future.  That puts this join condition
at risk: "pd.objsubid = c.ordinal_position".

You'd likely be better off to join pg_class and pg_attribute to
pg_description, rather than working with proxies for them.

https://www.postgresql.org/docs/current/catalogs.html

            regards, tom lane


pgsql-general by date:

Previous
From: Durgamahesh Manne
Date:
Subject: Re: Regarding query execution for long time
Next
From: Andrew Gierth
Date:
Subject: Re: Displaying Comments in Views