Re: remove ancient pre-dlopen dynloader code - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove ancient pre-dlopen dynloader code
Date
Msg-id 8022.1534425734@sss.pgh.pa.us
Whole thread Raw
In response to Re: remove ancient pre-dlopen dynloader code  (Andres Freund <andres@anarazel.de>)
Responses Re: remove ancient pre-dlopen dynloader code
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> This now generates a super nitpicky warning on at at least some linux +
> clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> change added:
> dynloader.c:7:4: warning: ISO C requires a translation unit to contain at least one declaration
[-Wempty-translation-unit]

We've been seeing that (or equivalents) on other platforms for years,
if not decades.  I can't get too excited about it really.

The lazy man's way to get rid of it would be to put something like
"int bogus = 0;" in the empty dynloader.c files.  Better would be
to not have the empty .c files at all, but I'm not sure how much
we'd have to contort the Makefiles to support that.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: C99 compliance for src/port/snprintf.c
Next
From: Dian Fay
Date:
Subject: Re: docs: note ownership requirement for refreshing materializedviews