Hello Andrey,
we would like to see ICU collations become the default for entire
databases as well. Therefore we would also review the patch.
Unfortunately your Patch from late October does not apply on the current
master.
Besides of that I noticed the patch applies on master of October but
results in errors when compiling without "--with-icu" and executing
"make check-world":
> libpq.so: Warning: undefined reference to »get_collprovider_name«
> libpq.so: Warning: undefined reference to
»is_valid_nondefault_collprovider«
> libpq.so: Warning: undefined reference to »get_collprovider«
May be caused by your last modification:
> I've added LDFLAGS_INTERNAL += $(ICU_LIBS) in libpq, but I'm not
> entirely sure this is correct way to deal with complaints on ICU
> functions from libpq linking.
Best regards,
Marius Timmer
--
Westfälische Wilhelms-Universität Münster (WWU)
Zentrum für Informationsverarbeitung (ZIV)
Röntgenstraße 7-13
48149 Münster
+49 251 83 31158
marius.timmer@uni-muenster.de
https://www.uni-muenster.de/ZIV
