Re: PoC Refactor AM analyse API - Mailing list pgsql-hackers

From Denis Smirnov
Subject Re: PoC Refactor AM analyse API
Date
Msg-id 7DE8AE89-E082-4AD0-AB62-38720B83DDCD@arenadata.io
Whole thread Raw
In response to Re: PoC Refactor AM analyse API  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: PoC Refactor AM analyse API  (Zhihong Yu <zyu@yugabyte.com>)
Re: PoC Refactor AM analyse API  (Jaime Casanova <jcasanov@systemguards.com.ec>)
List pgsql-hackers
Thanks for your review, Heikki.

I have made the changes you have requested.

1. All modifications interconnected with column projection were reverted (they should be added in
https://commitfest.postgresql.org/31/2922if the current patch would be merged one day). 
2. I have returned PROGRESS_ANALYZE_* states.
3. qsort() was moved into heapam_acquire_sample_rows(). Also a comment was added, that the acquire_sample_rows() AM
functionmust return the tuples in a physical table order. 
4. table_beginscan_analyze() was removed as a redundant function.
5. acquire_sample_rows() comment about reservoir was changed.


Best regards,
Denis Smirnov | Developer
sd@arenadata.io 
Arenadata | Godovikova 9-17, Moscow 129085 Russia


Attachment

pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: Re: Implementing Incremental View Maintenance
Next
From: Paul Guo
Date:
Subject: Re: Two patches to speed up pg_rewind.