Re: [PATCH] Fix memory corruption in pg_shdepend.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Fix memory corruption in pg_shdepend.c
Date
Msg-id 7AC194E3-3742-4E6D-A83F-B861A2D5DC6A@yesql.se
Whole thread Raw
In response to Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 22 Oct 2021, at 20:34, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 22 Oct 2021, at 15:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> (By "here" I mean all of e3931d0, because it made the same omission
>>> in several places.)
>
>> The attached fixes the the two ones I spotted, are there any I missed?
>
> Ah, you're right, InsertPgAttributeTuples is the only other spot in
> that patch that's actually touching slots.  I'd skimmed it a little
> too quickly.

Thanks for confirming, unless there are objections I'll apply the fix to master
and backpatch to 14.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Experimenting with hash tables inside pg_dump
Next
From: Tom Lane
Date:
Subject: pg_dump versus ancient server versions