Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Fix memory corruption in pg_shdepend.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix memory corruption in pg_shdepend.c
Date
Msg-id 2763418.1634927690@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 22 Oct 2021, at 15:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (By "here" I mean all of e3931d0, because it made the same omission
>> in several places.)

> The attached fixes the the two ones I spotted, are there any I missed?

Ah, you're right, InsertPgAttributeTuples is the only other spot in
that patch that's actually touching slots.  I'd skimmed it a little
too quickly.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Experimenting with hash tables inside pg_dump
Next
From: Tom Lane
Date:
Subject: Re: Experimenting with hash tables inside pg_dump