Re: Non-decimal integer literals - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Non-decimal integer literals
Date
Msg-id 791aee01-f488-0706-2694-08c5b57a3bdd@enterprisedb.com
Whole thread Raw
In response to Re: Non-decimal integer literals  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: Non-decimal integer literals
Re: Non-decimal integer literals
Re: Non-decimal integer literals
List pgsql-hackers
On 15.11.22 11:31, Peter Eisentraut wrote:
> On 14.11.22 08:25, John Naylor wrote:
>> Regarding the patch, it looks good overall. My only suggestion would 
>> be to add a regression test for just below and just above overflow, at 
>> least for int2.
> 
> ok

This was a valuable suggestion, because this found some breakage.  In 
particular, the handling of grammar-level literals that overflow to 
"Float" was not correct.  (The radix prefix was simply stripped and 
forgotten.)  So I added a bunch more tests for this.  Here is a new patch.

Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: postgres_fdw binary protocol support
Next
From: Robert Haas
Date:
Subject: Re: fixing CREATEROLE