On Tue, Nov 22, 2022 at 8:36 PM Peter Eisentraut <
peter.eisentraut@enterprisedb.com> wrote:
>
> On 15.11.22 11:31, Peter Eisentraut wrote:
> > On 14.11.22 08:25, John Naylor wrote:
> >> Regarding the patch, it looks good overall. My only suggestion would
> >> be to add a regression test for just below and just above overflow, at
> >> least for int2.
> >
> > ok
>
> This was a valuable suggestion, because this found some breakage. In
> particular, the handling of grammar-level literals that overflow to
> "Float" was not correct. (The radix prefix was simply stripped and
> forgotten.) So I added a bunch more tests for this. Here is a new patch.
Looks good to me.
--
John Naylor
EDB:
http://www.enterprisedb.com
