On 11/6/21 15:30, Tom Lane wrote:
> Peter Geoghegan <pg@bowt.ie> writes:
>> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas <rhaas@postgresql.org> wrote:
>>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
>
>> I'm seeing a pretty straightforward looking compiler warning following
>> this commit:
>> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’
>
> And apparently, that file isn't getting built at all on the MSVC side:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19
>
I got annoyed by the warning so I marked the variable as assert-only.
Haven't done anything about the MSVC issue.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
