Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
Date
Msg-id 508673.1636209019@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List pgsql-committers
Tree view 
Peter Geoghegan <pg@bowt.ie> writes:
> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas <rhaas@postgresql.org> wrote:
>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

> I'm seeing a pretty straightforward looking compiler warning following
> this commit:
> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’

And apparently, that file isn't getting built at all on the MSVC side:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19

            regards, tom lane

pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Update obsolete reference in vacuumlazy.c.
Next
From: Tomas Vondra
Date:
Subject: pgsql: Mark mystreamer variable as PG_USED_FOR_ASSERTS_ONLY