> On Oct 21, 2020, at 1:47 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Robert Haas <robertmhaas@gmail.com> writes:
>> I was about to commit 0001, after making some cosmetic changes, when I
>> discovered that it won't link for me. I think there must be something
>> wrong with the NLS stuff. My version of 0001 is attached. The error I
>> got is:
>
> Well, the short answer would be "you need to add
>
> SHLIB_LINK += $(filter -lintl, $(LIBS))
>
> to the Makefile". However, I would vote against that, because in point
> of fact amcheck has no translation support, just like all our other
> contrib modules. What should likely happen instead is to rip out
> whatever code is overoptimistically expecting it needs to support
> translation.
Done that way in the attached, which also include Robert's changes from v19 he posted earlier today.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
