Re: replace strtok() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: replace strtok()
Date
Msg-id 778789.1719071301@sss.pgh.pa.us
Whole thread Raw
In response to Re: replace strtok()  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: replace strtok()
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> On 18.06.24 13:43, Ranier Vilela wrote:
>> I found another implementation of strsep, it seems lighter to me.
>> I will attach it for consideration, however, I have not done any testing.

> Yeah, surely there are many possible implementations.  I'm thinking, 
> since we already took other str*() functions from OpenBSD, it makes 
> sense to do this here as well, so we have only one source to deal with.

Why not use strpbrk?  That's equally thread-safe, it's been there
since C89, and it doesn't have the problem that you can't find out
which of the delimiter characters was found.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: replace strtok()
Next
From: Melanie Plageman
Date:
Subject: Re: FreezeLimit underflows in pg14 and 15 causing incorrect behavior in heap_prepare_freeze_tuple