Re: [HACKERS] Index only scan for cube and seg - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [HACKERS] Index only scan for cube and seg
Date
Msg-id 764057ED-BE57-49E0-B10A-19C80F956108@yandex-team.ru
Whole thread Raw
In response to Re: [HACKERS] Index only scan for cube and seg  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses [HACKERS] How to implement a SP-GiST index as a extension module?
Re: [HACKERS] Index only scan for cube and seg
List pgsql-hackers
Hi!
> 29 окт. 2017 г., в 2:24, Alexander Korotkov <a.korotkov@postgrespro.ru> написал(а):
>
> As I can see, cube GiST code always uses DatumGetNDBOX() macro to transform Datum to (NDBOX *).
>
> #define DatumGetNDBOX(x)    ((NDBOX *) PG_DETOAST_DATUM(x))
>
> Thus, it should be safe to just remove both compress/decompress methods from existing opclass.

Alexander, Tom, you are absolutely right. I was sure there is toasting code in cube's compress, but it was not ever
there.

Here is patch for cube that drops functions.

Best regards, Andrey Borodin.



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Parallel worker error
Next
From: Chris Travers
Date:
Subject: Re: [HACKERS] proposal: schema variables