RE: User defined data types in Logical Replication - Mailing list pgsql-hackers

From Huong Dangminh
Subject RE: User defined data types in Logical Replication
Date
Msg-id 75DB81BEEA95B445AE6D576A0A5C9E936A6DB28E@BPXM05GP.gisp.nec.co.jp
Whole thread Raw
In response to Re: User defined data types in Logical Replication  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: User defined data types in Logical Replication
List pgsql-hackers
Hi Sawada-san,

> Thank you for quick response. The changes look good to me. But I wonder
> if the following changes needs some comments to describe what each checks
> does for.
> 
> -    if (errarg->attnum < 0)
> +    if (errarg->local_attnum <0)
> +        return;
> +
> +    rel = errarg->rel;
> +    remote_attnum = rel->attrmap[errarg->local_attnum];
> +
> +    if (remote_attnum < 0)
>          return;

Thanks, I have added some comments as you mentioned.


---
Thanks and best regards,
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: explain analyze output with parallel workers - question aboutmeaning of information for explain.depesz.com
Next
From: Magnus Hagander
Date:
Subject: Re: Basebackups reported as idle