Q about heap_getattr - Mailing list pgsql-hackers

From Tom Lane
Subject Q about heap_getattr
Date
Msg-id 7593.917200438@sss.pgh.pa.us
Whole thread Raw
List pgsql-hackers
I've been doing some more backend profiling, and observe that in a large
SELECT from a table with lots of columns, nocachegetattr (the guts of
heap_getattr) is at the top of the list, accounting for about 15% of
runtime.

The percentage would be lower in a table with fewer columns or no null
columns, but it still seems worth working on.  (Besides, this case right
here is a real-world case for me.)

What's drawing my eye is that printtup() is calling heap_getattr twice
for each attribute of each tuple --- once in the first scan that
prepares the null-fields bitmap, and then again to actually output the
field value.  So, what I want to do is call heap_getattr only once per
attribute and save the returned value for use in the second loop.
That should halve the time spent in nocachegetattr and thus knock
7 or so percent off the runtime of SELECT.

The question for the list: how long is the Datum value returned by
heap_getattr valid?  In particular, could it be invalidated by calling
heap_getattr for another field of the same tuple?  If there are any
cases like that, then this optimization won't work.  I don't know the
backend well enough to guess whether this is safe.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "D'Arcy" "J.M." Cain
Date:
Subject: Re: [HACKERS] Adding some const keywords to external interfaces
Next
From: Vadim Mikheev
Date:
Subject: Re: [HACKERS] Q about heap_getattr