Re: [HACKERS] Adding some const keywords to external interfaces - Mailing list pgsql-hackers

From D'Arcy" "J.M." Cain
Subject Re: [HACKERS] Adding some const keywords to external interfaces
Date
Msg-id m104QQc-0000buC@druid.net
Whole thread Raw
In response to Re: [HACKERS] Adding some const keywords to external interfaces  (Bruce Momjian <maillist@candle.pha.pa.us>)
Responses Re: [HACKERS] Adding some const keywords to external interfaces  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
Thus spake Bruce Momjian
> These are good points.  Can you post the patch again?  I deleted it. 

I bounced it directly to you rather than reposting to the list.

> Sounds like it would be safe.  I am interested in const-ify-ing the
> backend code, if possible.  It does offer a level of code checking that
> we don't currently have.

Me too but as I said, this patch doesn't do that.  It only const-ifies
the the arguments to an external interface.

> The only issue is that is has to be done pretty exhaustively.  If you
> don't, your new const function parameters start passing params to
> functions that takes non-const params, and warnings start to fly.

I compiled the entire tree without any warnings so I assume that the
changes wound up being pretty localized.

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.


pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: Re: [HACKERS] ecpg docs
Next
From: Tom Lane
Date:
Subject: Q about heap_getattr