Re: [HACKERS] Adding some const keywords to external interfaces - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Adding some const keywords to external interfaces
Date
Msg-id 199902021836.NAA28569@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Adding some const keywords to external interfaces  ("D'Arcy" "J.M." Cain <darcy@druid.net>)
Responses Re: [HACKERS] Adding some const keywords to external interfaces
List pgsql-hackers
We agreed to skip this right now, right?


> Thus spake Bruce Momjian
> > These are good points.  Can you post the patch again?  I deleted it. 
> 
> I bounced it directly to you rather than reposting to the list.
> 
> > Sounds like it would be safe.  I am interested in const-ify-ing the
> > backend code, if possible.  It does offer a level of code checking that
> > we don't currently have.
> 
> Me too but as I said, this patch doesn't do that.  It only const-ifies
> the the arguments to an external interface.
> 
> > The only issue is that is has to be done pretty exhaustively.  If you
> > don't, your new const function parameters start passing params to
> > functions that takes non-const params, and warnings start to fly.
> 
> I compiled the entire tree without any warnings so I assume that the
> changes wound up being pretty localized.
> 
> -- 
> D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
> http://www.druid.net/darcy/                |  and a sheep voting on
> +1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.
> 
> 


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: ecpg patch
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] help bug and comment char.