Re: Reduce the instruction overhead of OpenSSL calls - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Reduce the instruction overhead of OpenSSL calls
Date
Msg-id 751A4F25-79A6-425B-8323-C626BD300875@yesql.se
Whole thread Raw
In response to Reduce the instruction overhead of OpenSSL calls  ("ryanewang(王蕾)" <ryanewang@tencent.com>)
List pgsql-hackers
> On 27 Feb 2025, at 14:16, ryanewang(王蕾) <ryanewang@tencent.com> wrote:
>
> Hi,
> From the openssl documentation, when the value of ret is greater than 0, the SSL_get_error() function returns
SSL_ERROR_NONE. 
> So, it seems that when the return value of SSL_read() or SSL_write() function is greater than 0, we don't need to
makean error judgment.  
> The attached patch attempts to reduce unnecessary error judgments.

Calling SSL_get_error() is needed to clear the error queue for subsequent IO
operations, so I don't skipping it would be wise.  I imagine that any overhead
is dwarfed by the time spent in network IO anyways.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Re: Add Pipelining support in psql
Next
From: Josef Šimánek
Date:
Subject: Re: tests for pg_stat_progress_copy.tuples_skipped