Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT.
Date
Msg-id 7490.1463000940@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT.  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Peter Geoghegan wrote:
>> What does this mean?
>>
>> +           /* XXX broken */
>> if (attno < 0)
>> elog(ERROR, "system column in index");

> My guess is that it means we do support indexes in system columns (oid
> in particular) and that instead of an ugly error this should do
> something else.  Maybe silently ignore the index.

I left that for a second patch, which is now pushed.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix infer_arbiter_indexes() to not barf on system columns.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Small wording change for clarity