Re: Hash Index Build Patch v2 - Mailing list pgsql-patches

From Tom Lane
Subject Re: Hash Index Build Patch v2
Date
Msg-id 7368.1205709807@sss.pgh.pa.us
Whole thread Raw
In response to Hash Index Build Patch v2  (Tom Raney <twraney@comcast.net>)
Responses Re: Hash Index Build Patch v2  (Tom Raney <twraney@comcast.net>)
List pgsql-patches
Tom Raney <twraney@comcast.net> writes:
> This revised version of our patch uses the function estimate_rel_size()
> from plancat.c to estimate the number of tuples in the parent relation.
> This method is an alternative to scanning the parent relation to
> estimate the number of tuples, as we did in the first version of the patch.

Applied after significant editorialization.  You need to pay more
attention to conforming to the style of the surrounding code and to
updating comments that your work renders inaccurate.

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Suppress compiler warnings on mingw
Next
From: Tom Lane
Date:
Subject: Re: sinval.c / sinvaladt.c restructuring