Re: Hash Index Build Patch v2 - Mailing list pgsql-patches

From Tom Raney
Subject Re: Hash Index Build Patch v2
Date
Msg-id 47DF204B.9010804@comcast.net
Whole thread Raw
In response to Re: Hash Index Build Patch v2  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom,

Thanks for your comments and for your work incorporating our patch into
8.4.  This will help us provide even a better patch next time around :)

-Shreya Bhargava and Tom Raney

> Tom Raney <twraney@comcast.net> writes:
>
>> This revised version of our patch uses the function estimate_rel_size()
>> from plancat.c to estimate the number of tuples in the parent relation.
>> This method is an alternative to scanning the parent relation to
>> estimate the number of tuples, as we did in the first version of the patch.
>>
>
> Applied after significant editorialization.  You need to pay more
> attention to conforming to the style of the surrounding code and to
> updating comments that your work renders inaccurate.
>
>             regards, tom lane
>
>


pgsql-patches by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: [HACKERS] Proposal: new large object API
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Proposal: new large object API