Re: pg_amcheck contrib application - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: pg_amcheck contrib application
Date
Msg-id 71C96F66-2FC5-4F45-BFBA-2AB91AF091B1@enterprisedb.com
Whole thread Raw
In response to Re: pg_amcheck contrib application  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pg_amcheck contrib application  (Mark Dilger <mark.dilger@enterprisedb.com>)
List pgsql-hackers

> On Apr 30, 2021, at 12:47 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> Hmm, I think that might need adjustment, actually. What I was trying
> to do is compensate for the fact that what we now have is the next
> chunk_seq value we expect, not the last one we saw, nor the total
> number of chunks we've seen regardless of what chunk_seq they had. But
> I thought it would be too confusing to just give the chunk number we
> were expecting and not say anything about how many chunks we thought
> there would be in total. So maybe what I should do is change it to
> something like this:
>
> toast value %u was expected to end at chunk %d, but ended while
> expecting chunk %d
>
> i.e. same as the currently-committed code, except for changing "ended
> at" to "ended while expecting."

I find the grammar of this new formulation anomalous for hard to articulate reasons not quite the same as but akin to
mismatchedverb aspect. 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_amcheck contrib application
Next
From: Mark Dilger
Date:
Subject: Re: pg_amcheck contrib application