[HACKERS] Crash when partition column specified twice - Mailing list pgsql-hackers

From Amit Langote
Subject [HACKERS] Crash when partition column specified twice
Date
Msg-id 6ed23d3d-c09d-4cbc-3628-0a8a32f750f4@lab.ntt.co.jp
Whole thread Raw
Responses Re: [HACKERS] Crash when partition column specified twice  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
Noticed that a crash occurs if a column is specified twice when creating a
partition:

create table p (a int) partition by list (a);

-- crashes
create table p1 partition of parent (
  a not null,
  a default 1
) for values in (1);

The logic in MergeAttributes() that merged partition column options with
those of the parent didn't properly check for column being specified twice
and instead tried to delete the same ColumnDef from a list twice, causing
the crash.

Attached fixes that.

Added to the open items list.

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: [HACKERS] Inefficient shutdown of pg_basebackup
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] scram and \password