Re: [HACKERS] Crash when partition column specified twice - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] Crash when partition column specified twice
Date
Msg-id 346223c6-ee7d-feeb-b583-8fc8a5bf7ab7@lab.ntt.co.jp
Whole thread Raw
In response to [HACKERS] Crash when partition column specified twice  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] Crash when partition column specified twice  (Beena Emerson <memissemerson@gmail.com>)
List pgsql-hackers
On 2017/04/27 12:36, Amit Langote wrote:
> Noticed that a crash occurs if a column is specified twice when creating a
> partition:
> 
> create table p (a int) partition by list (a);
> 
> -- crashes
> create table p1 partition of parent (
>   a not null,
>   a default 1
> ) for values in (1);
> 
> The logic in MergeAttributes() that merged partition column options with
> those of the parent didn't properly check for column being specified twice
> and instead tried to delete the same ColumnDef from a list twice, causing
> the crash.
> 
> Attached fixes that.

Patch rebased, because of a conflict with b9a3ef55b2.

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Neha Khatri
Date:
Subject: Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Interval for launching the table sync worker