Re: partitioned tables and contrib/sepgsql - Mailing list pgsql-hackers

From Joe Conway
Subject Re: partitioned tables and contrib/sepgsql
Date
Msg-id 6d700f91-6bcb-9092-c897-501c7228975f@joeconway.com
Whole thread Raw
In response to Re: partitioned tables and contrib/sepgsql  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: partitioned tables and contrib/sepgsql  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 04/04/2017 09:58 PM, Tom Lane wrote:
> I doubt that works at all, TBH.  What I'd expect to happen with a
> typical compiler is a complaint about redefinition of typedef bool,
> because c.h already declared it and here this fragment is doing
> so again.  It'd make sense to me to do
>
> + #ifdef bool
> + #undef bool
> + #endif
>
> to get rid of the macro definition of bool that stdbool.h is
> supposed to provide.  But there should be no reason to declare
> our typedef a second time.

makes sense

> Another issue is whether you won't get compiler complaints about
> redefinition of the "true" and "false" macros.  But those would
> likely only be warnings, not flat-out errors.

I have not been able to generate warnings or errors around "true" and
"false".

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Logical decoding on standby
Next
From: Peter Eisentraut
Date:
Subject: Re: Logical Replication and Character encoding