Re: Logical Replication and Character encoding - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Logical Replication and Character encoding
Date
Msg-id 5401fef6-c0c0-7e8a-d8b1-169e30cbd854@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Logical Replication and Character encoding  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: Logical Replication and Character encoding  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
After further thinking, I prefer the alternative approach of using
pq_sendcountedtext() as is and sticking the trailing zero byte on on the
receiving side.  This is a more localized change, and keeps the logical
replication protocol consistent with the main FE/BE protocol.  (Also, we
don't need to send a useless byte around.)

Patch attached, and also a test case.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: partitioned tables and contrib/sepgsql
Next
From: Fujii Masao
Date:
Subject: Re: Quorum commit for multiple synchronous replication.