Re: [PATCHES] Adminpack build fix - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] Adminpack build fix
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FC91@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] Adminpack build fix  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] Adminpack build fix  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> >> The reason for redeclaring these in the contrib files is to get
> >> DLLIMPORT onto them...
>
> > Interedting - it builds on MSVC without it :-O
>
> > Anyway. That certainly explains why MSVC is complaining -
> it's getting
> > completely different definitions of these variables from the header
> > and from the actual file.
>
> The same redeclaration technique is being used elsewhere
> (pg_buffercache and pg_freespacemap it looks like).  Aren't
> you getting warnings there too?

I am - I just started working on getting those done as well. (they were
also living on my list of fix-later ones for some other reasons - the
other reasons now having been fixed)

//Magnus

pgsql-hackers by date:

Previous
From: "Magnus Hagander"
Date:
Subject: qsort vs MSVC build
Next
From: "Magnus Hagander"
Date:
Subject: CVS repository rsync