Re: [PATCHES] Adminpack build fix - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Adminpack build fix
Date
Msg-id 29576.1161280041@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Adminpack build fix  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: [PATCHES] Adminpack build fix  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
>> The reason for redeclaring these in the contrib files is to
>> get DLLIMPORT onto them...

> Interedting - it builds on MSVC without it :-O

> Anyway. That certainly explains why MSVC is complaining - it's getting
> completely different definitions of these variables from the header and
> from the actual file.

The same redeclaration technique is being used elsewhere (pg_buffercache
and pg_freespacemap it looks like).  Aren't you getting warnings there
too?

            regards, tom lane

pgsql-hackers by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: [PATCHES] Adminpack build fix
Next
From: "Magnus Hagander"
Date:
Subject: qsort vs MSVC build