Re: Couple of minor fixes - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: Couple of minor fixes
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0F8F4@algol.sollentuna.se
Whole thread Raw
In response to Couple of minor fixes  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: Couple of minor fixes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> > 2) timezone/localtime.c, transtime() has a const arcument in the
> > implementation but non-const in declaration.
>
> I did this the other way (make implementation match declaration).
> I think the coding was in fact correct per spec, because
> const-ness of an argument value is not part of the function signature.

Ok.


> > I'm also seeing a lot of signed/unsigned mismatch, but IIRC it was
> > said at some point that we don't care about those.
>
> In HEAD?  They're all cleaned up according to the compilers I use.

Yup.
More digging then I guess. Probably a #define that's messe dup
somewhere.

//Magnus

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Couple of minor fixes
Next
From: Tom Lane
Date:
Subject: Re: Couple of minor fixes