Re: [PATCH] Prompt for password on Windows platforms - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: [PATCH] Prompt for password on Windows platforms
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0F80F@algol.sollentuna.se
Whole thread Raw
In response to [PATCH] Prompt for password on Windows platforms  ("Robert Kinberg" <kinberg@tecore.com>)
List pgsql-patches
> >> (Specifically, it's bad that we open /dev/tty for writing
> even if we
> >> failed it for reading (that will create a new file), and that we
> >> don't check if it's a tty at all).
>
> > Maybe we should stat the file and check that it's actually
> a character
> > special device.
>
> On any sane Unix installation, /dev is not user-writable ...
> and I've never heard of one without /dev/tty, either.  So the
> above risk seems illusory, except on Windows.

That was kind of my main guess, but I don't know enough different Unix
flavours to state it. I'm sure you do :-)

Given that, please just go with the win32-only solution.

/Magnus

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Prompt for password on Windows platforms
Next
From: Neil Conway
Date:
Subject: Re: 2 line patch to allow plpythonu functions to return