Re: [PATCH] Prompt for password on Windows platforms - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PATCH] Prompt for password on Windows platforms
Date
Msg-id 29192.1141161505@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Prompt for password on Windows platforms  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Andrew Dunstan <andrew@dunslane.net> writes:
> Magnus Hagander wrote:
>> (Specifically, it's bad that we open /dev/tty for writing even if we
>> failed it for reading (that will create a new file), and that we don't
>> check if it's a tty at all).

> Maybe we should stat the file and check that it's actually a character
> special device.

On any sane Unix installation, /dev is not user-writable ... and I've
never heard of one without /dev/tty, either.  So the above risk seems
illusory, except on Windows.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: [PATCH] Prompt for password on Windows platforms
Next
From: "Magnus Hagander"
Date:
Subject: Re: [PATCH] Prompt for password on Windows platforms