Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE92E794@algol.sollentuna.se
Whole thread Raw
List pgsql-hackers
> > But. in theory, we can get a false positive from
> > UNBLOCKED_SIGNAL_QUEUE(), right?
>
> We could have gotten a false positive from the old coding, too.
> The event was certainly not any more tightly tied to the
> presence of an unserviced signal flag than
> UNBLOCKED_SIGNAL_QUEUE, and arguably less so.
>
> I think this concern is irrelevant anyway.  Returning EINTR from
> select() is OK even if no signal was actually serviced, so
> long as it doesn't recur indefinitely.  EINTR just means "I
> didn't do the select(), try again".

Ok. I don't see any way why it would recur indefinitly, since we'll
clean it up in the dispatch routine. And any half-updated-value will be
fully updated a *very* short time later. So we sohuld be fine.

//Magnus


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance