Re: [HACKERS] s_lock.h cleanup - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] s_lock.h cleanup
Date
Msg-id 6698.979876169@sss.pgh.pa.us
Whole thread Raw
In response to s_lock.h cleanup  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] s_lock.h cleanup  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
As long as we're cleaning things up, I would suggest that all the ports
that use gcc assembler be made to declare it uniformly, as

    __asm__ __volatile__ ( ... );

As I read the GCC manual, there's some risk of the asm sections getting
moved around in the program flow if they are not marked volatile.  Also
we oughta be consistent about using the double-underscore keywords IMHO.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: s_lock.h cleanup
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] s_lock.h cleanup