Re: s_lock.h cleanup - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: s_lock.h cleanup
Date
Msg-id 200101190358.WAA08973@candle.pha.pa.us
Whole thread Raw
In response to Re: s_lock.h cleanup  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Done and applied.

> As long as we're cleaning things up, I would suggest that all the ports
> that use gcc assembler be made to declare it uniformly, as
>
>     __asm__ __volatile__ ( ... );
>
> As I read the GCC manual, there's some risk of the asm sections getting
> moved around in the program flow if they are not marked volatile.  Also
> we oughta be consistent about using the double-underscore keywords IMHO.
>
>             regards, tom lane
>


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: s_lock.h cleanup
Next
From: "Patrick Dunford"
Date:
Subject: FW: User management