Re: Subtle bug in autoconf flex version test - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Subtle bug in autoconf flex version test
Date
Msg-id 65577F12-8F04-4082-A89A-27ED1F3B690A@yesql.se
Whole thread Raw
In response to Re: Subtle bug in autoconf flex version test  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Subtle bug in autoconf flex version test  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 02 May 2016, at 15:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> The PGAC_PATH_FLEX version test in config/programs.m4 tests the major and minor
>> versions with = rather than == which unless I’m missing something is performing
>> assignment rather than testing equality?
>
> Huh.  That's been broken since forever ... thanks for noticing!
>
>> The attached diff makes the test
>> trigger the expected warning on major/minor version on my OS X box (awk version
>> 20070501).
>
> Hm, is that a popular flex version?  I wonder whether we will get
> complaints if we start warning about it.

Sorry, I missed half the sentence there.  What I meant was that I can trigger
the warning synthetically by changing the version number just to test the
warning; before any version is happily accepted.

cheers ./daniel




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Timeline following for logical slots
Next
From: Alvaro Herrera
Date:
Subject: Re: Timeline following for logical slots