Re: Miscellaneous changes to plperl [PATCH] - Mailing list pgsql-hackers

From David E. Wheeler
Subject Re: Miscellaneous changes to plperl [PATCH]
Date
Msg-id 63E5EAC5-9D15-4976-99E6-9E2E44AC9DC9@kineticode.com
Whole thread Raw
In response to Re: Miscellaneous changes to plperl [PATCH]  (Alex Hunsaker <badalex@gmail.com>)
Responses Re: Miscellaneous changes to plperl [PATCH]  (Alex Hunsaker <badalex@gmail.com>)
Re: Miscellaneous changes to plperl [PATCH]  (Tim Bunce <Tim.Bunce@pobox.com>)
List pgsql-hackers
On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:

> Well no, i suppose we could fix that via:
> $name =~ s/[:|']/_/g;
>
> Im betting that was the intent.

Doubtful. In Perl, the package separator is either `::` or `'` (for hysterical reasons). So the original code was
replacingany package separator with a single underscore. Your regex would change This::Module to This__Module, which
I'mcertain was not the intent. 

Best,

David

pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: commit fests
Next
From: Andrew Dunstan
Date:
Subject: Re: 8.5 vs. 9.0, Postgres vs. PostgreSQL