Re: Miscellaneous changes to plperl [PATCH] - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: Miscellaneous changes to plperl [PATCH]
Date
Msg-id 34d269d41001231153k2140af24k17393bdae65780e@mail.gmail.com
Whole thread Raw
In response to Re: Miscellaneous changes to plperl [PATCH]  ("David E. Wheeler" <david@kineticode.com>)
Responses Re: Miscellaneous changes to plperl [PATCH]
List pgsql-hackers
On Sat, Jan 23, 2010 at 12:42, David E. Wheeler <david@kineticode.com> wrote:
> On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:
>
>> Well no, i suppose we could fix that via:
>> $name =~ s/[:|']/_/g;
>>
>> Im betting that was the intent.
>
> Doubtful. In Perl, the package separator is either `::` or `'` (for hysterical reasons). So the original code was
replacingany package separator with a single underscore. Your regex would change This::Module to This__Module, which
I'mcertain was not the intent. 

Haha, yep your right.  I could have sworn I tested it with a function
name with a ' and it broke.  But your obviously right :)


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: 8.5 vs. 9.0, Postgres vs. PostgreSQL
Next
From: Tom Lane
Date:
Subject: Re: commit fests