Re: pg_buffercache: add sql test - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_buffercache: add sql test
Date
Msg-id 628172.1659209978@sss.pgh.pa.us
Whole thread Raw
In response to pg_buffercache: add sql test  (Dong Wook Lee <sh95119@gmail.com>)
Responses Re: pg_buffercache: add sql test
Re: pg_buffercache: add sql test
List pgsql-hackers
Dong Wook Lee <sh95119@gmail.com> writes:
> I just wrote a test code for the `pg_buffercache` extension which
> doesn't not have test code.

Pushed with minor adjustments.  Some notes:

* A .gitignore file is needed so that "git status" won't whine after
running the test.  This tends to be pretty much boilerplate; I copied
it from another contrib directory.

* Pay attention to "git diff --check" formatting warnings.  In this
case it bleated about an extra blank line at the end of the .sql file.

* I didn't care for the direct use of pg_show_all_settings().  The
official API there is the pg_settings view, and there's no need for
this test to get friendly with the view's internals.

Thanks for the patch!

            regards, tom lane



pgsql-hackers by date:

Previous
From: Matheus Alcantara
Date:
Subject: Re: Trying to add more tests to gistbuild.c
Next
From: Tom Lane
Date:
Subject: Re: Trying to add more tests to gistbuild.c