Re: postgres_fdw vs data formatting GUCs (was Re: [v9.3] writable foreign tables) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: postgres_fdw vs data formatting GUCs (was Re: [v9.3] writable foreign tables)
Date
Msg-id 6278.1363799610@sss.pgh.pa.us
Whole thread Raw
In response to Re: postgres_fdw vs data formatting GUCs (was Re: [v9.3] writable foreign tables)  (Daniel Farina <daniel@heroku.com>)
Responses Re: postgres_fdw vs data formatting GUCs (was Re: [v9.3] writable foreign tables)
List pgsql-hackers
Daniel Farina <daniel@heroku.com> writes:
> On Wed, Mar 20, 2013 at 7:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Um ... you shouldn't need a PG_TRY for that at all.  guc.c will take
>> care of popping the values on transaction abort --- that's really rather
>> the whole point of having that mechanism.

> Hmm, well, merely raising the error doesn't reset the GUCs, so I was
> rather thinking that this was a good idea to compose more neatly in
> the case of nested exception processing, e.g.:

In general, we don't allow processing to resume after an error until
transaction or subtransaction abort cleanup has been done.  It's true
that if you look at the GUC state in a PG_CATCH block, you'll see it
hasn't been reset yet, but that's not very relevant.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Atri Sharma
Date:
Subject: Re: [pgsql-advocacy] Call for Google Summer of Code mentors, admins
Next
From: Tom Lane
Date:
Subject: Re: pg_upgrade segfaults when given an invalid PGSERVICE value