Re: BETWEEN Node & DROP COLUMN - Mailing list pgsql-hackers

From Tom Lane
Subject Re: BETWEEN Node & DROP COLUMN
Date
Msg-id 627.1025761845@sss.pgh.pa.us
Whole thread Raw
In response to Re: BETWEEN Node & DROP COLUMN  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: BETWEEN Node & DROP COLUMN
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> No, he only breaks even for client cleanliness --- either approach
>> *will* require changes in clients that look at pg_attribute.

> Uh, Christopher already indicated three clients, psql, pg_dump, and
> another that will not require changes for Hiroshi's approach, but will
> require changes for isdropped.

Oh?  If either psql or pg_dump don't break, it's a mere coincidence,
because they certainly depend on attnum.  (It's also pretty much
irrelevant considering they're both under our control and hence easily
fixed.)

I'm fairly certain that Christopher is mistaken, anyhow.  Check the
manipulations of attribute defaults for a counterexample in pg_dump.
        regards, tom lane




pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] [SQL] pg_restore cannot restore function
Next
From: Hiroshi Inoue
Date:
Subject: Re: BETWEEN Node & DROP COLUMN