Re: [PATCHES] [SQL] pg_restore cannot restore function - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] [SQL] pg_restore cannot restore function
Date
Msg-id 200207040539.g645dVx01650@candle.pha.pa.us
Whole thread Raw
List pgsql-hackers
pgman wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > The following patch fixes all of these, and it will be in 7.3.
> > 
> > It will?  Kindly explain what the heck this is doing.  It looks to
> > me like it will probably break more cases than it fixes.  AFAICS
> > it's just completely muddying the waters about what is quoted and
> > what isn't ...
> 
> Well, the waters were already muddy.  Doing a pg_dump -Ft, you will see
> with the old code how the tags for functions had quotes, and how the
> GRANT/REVOKE has quotes for table names, while the CREATE TABLE tags for
> these do not.  This fixes that, and tries to get the -P string they
> enter for pg_restore to match the tag by removing spaces.

In summary, the tags stored by pg_dump should _not_ have quotes. 
Function names and GRANT/REVOKE were coming out with quotes around them
in pg_dump -Ft format.  This does not change the ASCII output, which is
always quoted.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 




pgsql-hackers by date:

Previous
From: Thomas Lockhart
Date:
Subject: Re: BETWEEN Node & DROP COLUMN
Next
From: Tom Lane
Date:
Subject: Re: BETWEEN Node & DROP COLUMN