Re: Some belated patch review for "Buffers" explain analyze patch - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Some belated patch review for "Buffers" explain analyze patch
Date
Msg-id 603c8f071002091423u2201f7b0ke88973373b5b99c9@mail.gmail.com
Whole thread Raw
In response to Re: Some belated patch review for "Buffers" explain analyze patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Some belated patch review for "Buffers" explain analyze patch
List pgsql-hackers
On Tue, Feb 9, 2010 at 5:07 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Feb 9, 2010 at 3:26 PM, Josh Berkus <josh@agliodbs.com> wrote:
>>> I'd prefer to have the average; it's very confusing to have an explain
>>> row which has the cost per iteration, but the buffer usage per node.
>
>> The cost per iteration thing is IMO one of the most confusing parts of
>> the EXPLAIN output; I'm not really eager to see us replicate that
>> elsewhere.
>
> Well, if you want to put forward a proposal to get rid of that approach
> entirely, go ahead.  But it doesn't seem like a good idea to me for
> EXPLAIN to print some numbers according to one viewpoint and some
> according to the other.

Well, if I propose that we just abandon that approach and print only
totals for everything, is that DOA?  I think it would be a major
improvement, but it will break backward compatibility.

...Robert


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: Avoiding bad prepared-statement plans.
Next
From: Robert Haas
Date:
Subject: Re: Listen / Notify - what to do when the queue is full