Re: attoptions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: attoptions
Date
Msg-id 603c8f071001201851h19a88ec4n99291858fdf8ac5e@mail.gmail.com
Whole thread Raw
In response to Re: attoptions  (Alex Hunsaker <badalex@gmail.com>)
Responses Re: attoptions  (Alex Hunsaker <badalex@gmail.com>)
List pgsql-hackers
On Tue, Jan 19, 2010 at 10:51 AM, Alex Hunsaker <badalex@gmail.com> wrote:
> But yes, lets keep it simple for now.

OK.  Updated patch attached.  Changes:

- Incorporate your previous review patch.
- Omit attacl and attoptions from hardcoded relation descriptor
initializers so the whole thing still builds.- Use
ATSimplePermissionsRelationOrIndex instead of custom permissions
logic.
- Remove recursion, per further thought about a comment in your
original review - I agree that the recursive behavior is weird.
- Remove a stray reference to SET STATISTICS DISTINCT in the documentation.
- Bug fix: this wasn't working at all for index-expression columns.

...Robert

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: HS/SR and smart shutdown
Next
From: Fujii Masao
Date:
Subject: Re: Streaming Replication and archiving