Re: WIP: Column-level Privileges - Mailing list pgsql-hackers

From Robert Haas
Subject Re: WIP: Column-level Privileges
Date
Msg-id 603c8f070812021748m3f4cbc94h9ca0be3092f20885@mail.gmail.com
Whole thread Raw
In response to Re: WIP: Column-level Privileges  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Tue, Nov 25, 2008 at 4:03 PM, Stephen Frost <sfrost@snowman.net> wrote:
> * Alvaro Herrera (alvherre@commandprompt.com) wrote:
>> I had a look at aclchk.c and didn't like your change to
>> objectNamesToOids; seems rather baroque.  I changed it per the attached
>> patch.
>
> I've incorporated this change.
>
>> Moreover I didn't very much like the way aclcheck_error_col is dealing
>> with two or one % escapes.  I think you should have a separate routine
>> for the column case, and prepend a dummy string to no_priv_msg.
>
> I can do this, not really a big deal.

Stephen,

Are you sending an updated patch with these minor changes?

...Robert


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] GIN improvements
Next
From: Bruce Momjian
Date:
Subject: Re: Erroring out on parser conflicts