Re: Erroring out on parser conflicts - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Erroring out on parser conflicts
Date
Msg-id 200812030150.mB31ooY20949@momjian.us
Whole thread Raw
In response to Re: Erroring out on parser conflicts  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Erroring out on parser conflicts  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Peter Eisentraut wrote:
> On Tuesday 25 November 2008 15:09:37 Tom Lane wrote:
> > Peter Eisentraut <peter_e@gmx.net> writes:
> > > While hacking on parser/gram.y just now I noticed in passing that the
> > > automatically generated ecpg parser had 402 shift/reduce conflicts.
> > > (Don't panic, the parser in CVS is fine.)  If you don't pay very close
> > > attention, it is easy to miss this.  Considering also that we frequently
> > > have to educate contributors that parser conflicts are not acceptable,
> > > should we try to error out if we see conflicts?
> >
> > Would "%expect 0" produce the same result in a less klugy way?
> 
> Great, that works.  I'll see about adding this to our parser files.

FYI, this is going to make it hard for developers to test CVS changes
until they get their grammar cleaned up;  perhaps add a comment on how
to disable the check?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: "Robert Haas"
Date:
Subject: Re: WIP: Column-level Privileges
Next
From: Alvaro Herrera
Date:
Subject: Re: [BUG] lo_open() makes a warning/falls to an assertion